HDFS-17254. DataNode httpServer has too many worker threads#6307
Closed
2005hithlj wants to merge 1 commit intoapache:trunkfrom
Closed
HDFS-17254. DataNode httpServer has too many worker threads#63072005hithlj wants to merge 1 commit intoapache:trunkfrom
2005hithlj wants to merge 1 commit intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
LGTM. |
slfan1989
reviewed
Nov 30, 2023
| "dfs.datanode.http.internal-proxy.port"; | ||
| public static final String DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY = | ||
| "dfs.datanode.netty.worker.threads"; | ||
| public static final int DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT = 0; |
Contributor
There was a problem hiding this comment.
Thanks for your contribution, but is it reasonable to default to 0 for the number of threads?
Contributor
Author
There was a problem hiding this comment.
@slfan1989 Thank you for your review, the default value should not continue to be 0, and I plan to change the default value to 10. What do you think, sir?
Contributor
Author
There was a problem hiding this comment.
@slfan1989 I have changed the default value to 10, and it works normally in our HDFS cluster.
Contributor
|
@2005hithlj Thanks. Is it caused by enable webhdfs or http UI or some other reasons? |
Contributor
Author
|
@Hexiaoqiao sir. Thank you for your review, it caused by enable http UI. |
2005hithlj
force-pushed
the
HDFS-17254
branch
from
1888454 to
d911ba9
Compare
|
💔 -1 overall
This message was automatically generated. |
xinglin
approved these changes
Dec 7, 2023
slfan1989
approved these changes
Dec 9, 2023
Contributor
|
@2005hithlj Thanks for your contribution. Please also update hdfs-default.xml for the additional config item. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@Hexiaoqiao OK Sir, I have already fixed and committed it. |
tomscut
approved these changes
Dec 14, 2023
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_HTTP_ADDRESS_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_HTTP_INTERNAL_PROXY_PORT; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY; | ||
| import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT; |
Contributor
There was a problem hiding this comment.
Please add this configuration into hdfs-default.xml. Thanks.
tomscut
reviewed
Dec 14, 2023
| this.workerGroup = new NioEventLoopGroup(); | ||
| int workerThreads = conf.getInt(DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY, | ||
| DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT); | ||
| this.workerGroup = new NioEventLoopGroup(workerThreads); |
Contributor
There was a problem hiding this comment.
Better to use a cached thread pool here. this.workerGroup = new NioEventLoopGroup(workerCount, Executors.newCachedThreadPool()).
ayushtkn
reviewed
Dec 19, 2023
|
|
||
| <property> | ||
| <name>dfs.datanode.netty.worker.threads</name> | ||
| <value>10</value> |
Member
There was a problem hiding this comment.
Shouldn't the default be 0, to preserve the original behaviour, earlier we were passing 0 internally here?
this.workerGroup = new NioEventLoopGroup();
Contributor
There was a problem hiding this comment.
0 is probably not a good default value to use here. I think that is exactly why the author wanted to make it configurable. I don't think there is a strong need to preserve an not-ideal old behavior here.
Member
There was a problem hiding this comment.
Changing defaults is an incompatible change, it should stay the same. the code is there since 2014, if someone finds it isn't a good number he can configure explicitly
Contributor
There was a problem hiding this comment.
I don't have a strong opinion here. Either way works for me.
Comment on lines
149
to
151
| int workerThreads = conf.getInt(DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY, | ||
| DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT); |
Member
There was a problem hiding this comment.
Should validate this value, for -ve values, if it is -ve we should put a warn log & use default.
Contributor
Author
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Dec 29, 2023
| "dfs.datanode.http.internal-proxy.port"; | ||
| public static final String DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY = | ||
| "dfs.datanode.netty.worker.threads"; | ||
| public static final int DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT = 10; |
Member
There was a problem hiding this comment.
this needs to be changed as well
Contributor
Author
There was a problem hiding this comment.
@ayushtkn Thank you for your review, I have changed it.
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@slfan1989 @xinglin @Hexiaoqiao Are there any other suggestions for this PR? |
xinglin
approved these changes
Jan 26, 2024
Contributor
|
lots of unit test failures. Maybe could you create an empty commit and push it to trigger a new build?
|
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
2005hithlj
force-pushed
the
HDFS-17254
branch
2 times, most recently
from
28e38df to
da066dc
Compare
2005hithlj
force-pushed
the
HDFS-17254
branch
2 times, most recently
from
e4739a5 to
dd79100
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Hi @2005hithlj , Please check the failed unit tests if related to this PR first. |
ayushtkn
approved these changes
Sep 21, 2024
Comment on lines
153
to
155
| LOG.warn("The value of " + | ||
| DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY + " is less than 0, will use default value: " + | ||
| DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT); | ||
| workerCount = DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT; |
Member
There was a problem hiding this comment.
Use logger format {} instead of concat
Contributor
Author
There was a problem hiding this comment.
@ayushtkn Thanks for your review. I have revised it. could you take a look? Thanks.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-17254. DataNode httpServer has too many worker threads